Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Session Window and Reduce Streaming #87

Merged
merged 30 commits into from
Dec 19, 2023
Merged

feat: Session Window and Reduce Streaming #87

merged 30 commits into from
Dec 19, 2023

Conversation

yhl25
Copy link
Contributor

@yhl25 yhl25 commented Nov 23, 2023

  • A new server has been introduced specifically to execute SessionReducer operations and will listen to "/var/run/numaflow/sessionreduce.sock".

  • Made Proto modifications to support streaming reduce and session reduce.

  • A task manager is now included in all the reducers for better management of reduce tasks.

  • The reducer interface has been updated, it now returns a channel to support partial responses and early returns. (breaking change)

  • Type Messages from the reducer has been removed since the handler return type is now a channel. (breaking change)

Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
@yhl25 yhl25 changed the title feat: Session Window feat: Session Window and Reduce Streaming Nov 27, 2023
Signed-off-by: Yashash H L <[email protected]>
@yhl25 yhl25 requested review from whynowy and vigith November 27, 2023 15:13
Signed-off-by: Vigith Maurice <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
@yhl25 yhl25 requested a review from vigith December 8, 2023 11:00
@yhl25 yhl25 marked this pull request as ready for review December 8, 2023 11:11
Signed-off-by: Vigith Maurice <[email protected]>
pkg/apis/proto/globalreduce/v1/globalreduce.proto Outdated Show resolved Hide resolved
pkg/apis/proto/sessionreduce/v1/sessionreduce.proto Outdated Show resolved Hide resolved
pkg/globalreducer/doc.go Outdated Show resolved Hide resolved
pkg/reducer/examples/counter/go.mod Outdated Show resolved Hide resolved
@vigith
Copy link
Member

vigith commented Dec 8, 2023

let's also rethink the need of locking required in Aligned windows

Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
@vigith vigith requested a review from a team December 13, 2023 02:52
@yhl25 yhl25 requested a review from vigith December 19, 2023 08:20
@vigith vigith merged commit 2903e27 into main Dec 19, 2023
3 checks passed
@vigith vigith deleted the unaligned-window branch December 19, 2023 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants